Skip to content

1330 Refine generate_spatial_bounding_box API#1336

Merged
wyli merged 7 commits into
Project-MONAI:masterfrom
Nic-Ma:1330-refine-compute-bbox
Dec 9, 2020
Merged

1330 Refine generate_spatial_bounding_box API#1336
wyli merged 7 commits into
Project-MONAI:masterfrom
Nic-Ma:1330-refine-compute-bbox

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Dec 9, 2020

Copy link
Copy Markdown
Contributor

Fixes #1330 .

Description

This PR combined compute_bounding_rect and generate_spatial_bounding_box APIs.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma

Nic-Ma commented Dec 9, 2020

Copy link
Copy Markdown
Contributor Author

/black

wyli
wyli reviewed Dec 9, 2020
View reviewed changes
Comment thread monai/transforms/croppad/array.py Outdated
wyli
wyli reviewed Dec 9, 2020
View reviewed changes

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick pr, I put some comments inline

Comment thread monai/transforms/utils.py Outdated
Comment thread monai/transforms/utils.py Outdated
Comment thread monai/transforms/utils.py Outdated
Comment thread monai/transforms/utils.py
@Nic-Ma
[DLMED] update according to comments
c984e75 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Dec 9, 2020

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma

Nic-Ma commented Dec 9, 2020

Copy link
Copy Markdown
Contributor Author

Hi @wyli ,

Thanks for your review.
I updated the PR according to your comments, could you please help review it again?

Thanks.

@Nic-Ma
[DLMED] add check for margin value
cc215b5 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Dec 9, 2020 •
edited by wyli
Loading

Copy link
Copy Markdown
Contributor Author

/integration-test /black

wyli
wyli approved these changes Dec 9, 2020
View reviewed changes

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli merged commit 6b95e4d into Project-MONAI:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes
@ericspod ericspod Awaiting requested review from ericspod
@atbenmurray atbenmurray Awaiting requested review from atbenmurray

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Combine compute_bounding_rect and generate_spatial_bounding_box

2 participants

@Nic-Ma @wyli